If after two years he is still holding you at arms length and not letting you into his life, that says a something, regardless of whether he is a recovering addict. Gambling is as addictive as alcohol and can ruin finances even more quickly.
I think I'd definitely be concerned.